@dmohns can you please check this

@dmohns can you please check this

Sure, I will follow up with this next week 👌

Hey @munyanezaarmel

apologies for my delayed response here. I will take a look now 🕵️

Hey @munyanezaarmel

so, after reviewing this here are my thoughts. It looks like Laravel Pint is actually just a rule-set to PHP-CS-Fixer plus a small wrapper around it for nicer CLI integration. The exact rule configuration can be seen here: https://github.com/laravel/pint/blob/main/resources/presets/laravel.php

Now, I don't think there is a benefit of adding the tool it self then. I was originally hoping there is some additional rules and checks in there, which PHP-CS-Fixer cannot cover. But this doesn't seem to be the case.

None-the-less... I think some of the conventions that the Laravel rule set I actually like a lot. So there is something to take away from here.

Could you instead please adapt our current PHP-CS-Fixer rule set with the following rules:

        'method_chaining_indentation' => true,
        'braces_position' => [
            'control_structures_opening_brace' => 'same_line',
            'functions_opening_brace' => 'same_line',
            'anonymous_functions_opening_brace' => 'same_line',
            'classes_opening_brace' => 'same_line',
            'anonymous_classes_opening_brace' => 'same_line',
            'allow_single_line_empty_anonymous_classes' => true,
            'allow_single_line_anonymous_functions' => true,
        ],
        'method_argument_space' => [
            'on_multiline' => 'ensure_fully_multiline',
        ],
        'single_line_empty_body' => true,

?

Hey @munyanezaarmel

for changing the rules set of PHP-CS-Fixer, could you do the following:

1. Create a new branch (please dont use special characters like # in branch names)
2. Create exactly 2 commits in the branch. First is to update the rule set
3. Second commit should reformat the entire repo

Then we will merge this PR.

4. After that please create a new PR to add the commit that reformatted the repo to .git-blame-ignore-revs

Superseded by: #382